Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation link to legacy-js-api warning #2355

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Add documentation link to legacy-js-api warning #2355

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1763ef6
Add documentation link to legacy-js-api warning
jathak Sep 19, 2024
c247b07
Remove -dev from sass-parser
jathak Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@
`color.green()`, `color.blue()`, `color.hue()`, `color.saturation()`,
`color.lightness()`, `color.whiteness()`, and `color.blackness()`.

* Update deprecation warnings for the legacy JS API to include a link to
[relevant documentation].

[relevant documentation]: https://sass-lang.com/d/legacy-js-api

## 1.79.1

* No user-visible changes.
Expand Down
3 changes: 2 additions & 1 deletion lib/src/async_compile.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,8 @@ Future<CompileResult> _compileStylesheet(
logger?.warnForDeprecation(
Deprecation.legacyJsApi,
'The legacy JS API is deprecated and will be removed in '
'Dart Sass 2.0.0.');
'Dart Sass 2.0.0.\n\n'
'More info: https://sass-lang.com/d/legacy-js-api');
}
var evaluateResult = await evaluateAsync(stylesheet,
importCache: importCache,
Expand Down
5 changes: 3 additions & 2 deletions lib/src/compile.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
// DO NOT EDIT. This file was generated from async_compile.dart.
// See tool/grind/synchronize.dart for details.
//
// Checksum: 4141eec2214ef480b6fdf07e5090202cdea3eb89
// Checksum: 42c9e2008d449ba4b73b3b92a64cf4d51253837d
//
// ignore_for_file: unused_import

Expand Down Expand Up @@ -172,7 +172,8 @@ CompileResult _compileStylesheet(
logger?.warnForDeprecation(
Deprecation.legacyJsApi,
'The legacy JS API is deprecated and will be removed in '
'Dart Sass 2.0.0.');
'Dart Sass 2.0.0.\n\n'
'More info: https://sass-lang.com/d/legacy-js-api');
}
var evaluateResult = evaluate(stylesheet,
importCache: importCache,
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: sass
version: 1.79.2-dev
version: 1.79.2
description: A Sass implementation in Dart.
homepage: https://github.com/sass/dart-sass

Expand Down
Loading