Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow modulo zero #2593

Closed
nex3 opened this issue Mar 16, 2018 · 0 comments
Closed

Allow modulo zero #2593

nex3 opened this issue Mar 16, 2018 · 0 comments
Labels
Dev - Test Written

Comments

@nex3
Copy link
Contributor

nex3 commented Mar 16, 2018

A number modulo zero should produce NaN rather than failing. See sass/sass-spec#1228 and sass/sass-spec#1229.
mgreter added a commit to mgreter/libsass that referenced this issue Mar 17, 2018
@mgreter
Adjust output/error for modulo zero operation
91dd504 
Fixes sass#2593
@mgreter mgreter mentioned this issue Mar 17, 2018
Merged
mgreter added a commit that referenced this issue Mar 17, 2018
@mgreter
Adjust output/error for modulo zero operation
e5421e6 
Fixes #2593
xzyfer pushed a commit to xzyfer/libsass that referenced this issue Mar 23, 2018
@mgreter @xzyfer
Adjust output/error for modulo zero operation
4676e14 
Fixes sass#2593
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Dev - Test Written
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nex3 @mgreter