-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve ie property and expression parsing #1194
Conversation
0a29296
to
60f3439
Compare
b70825c
to
eedba4d
Compare
text += i; | ||
} else if (!inside_str && (i == '"' || i == '\'')) { | ||
} else if (false && !inside_str && (i == '"' || i == '\'')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, seems valid, can be gone ...
Spec PR sass/sass-spec#375 |
eedba4d
to
cd18ae8
Compare
👍 Also I wonder if parsing these ie expressions is worth the effort (and perf hit?). Could we get away with going back to treating these as |
Improve ie property and expression parsing
Fixes #1188
Fixes #1107
Fixes #1102
Fixes #931