Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for @keyframes nesting errors #1979

Merged
merged 3 commits into from
Apr 24, 2024
Merged

Add tests for @keyframes nesting errors #1979

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d2c83b5
Add tests for `@keyframes` nesting errors
nex3 Apr 22, 2024
864f7d2
Remove newly-failing test
nex3 Apr 22, 2024
8656354
Fix some incorrect tests
nex3 Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions spec/css/keyframes.hrx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,3 +248,48 @@ $a: b;
c: d;
}
}

<===>
================================================================================
<===> error/in_keyframe_block/style_rule/input.scss
@keyframes a {
to {b {c: d}}
}

<===> error/in_keyframe_block/style_rule/error
Error: Style rules may not be used within keyframe blocks.
,
2 | to {b {c: d}}
| ^^^^^^^^
'
input.scss 2:7 root stylesheet

<===>
================================================================================
<===> error/in_keyframe_block/unknown_at_rule/input.scss
@keyframes a {
to {@b}
}

<===> error/in_keyframe_block/unknown_at_rule/error
Error: At-rules may not be used within keyframe blocks.
,
2 | to {@b}
| ^^
'
input.scss 2:7 root stylesheet

<===>
================================================================================
<===> error/in_keyframe_block/known_at_rule/input.scss
@keyframes a {
to {@media {b: c}}
nex3 marked this conversation as resolved.
Show resolved Hide resolved
}

<===> error/in_keyframe_block/known_at_rule/error
Error: Expected identifier.
,
2 | to {@media {b: c}}
| ^
'
input.scss 2:14 root stylesheet
6 changes: 0 additions & 6 deletions spec/libsass/selectors/simple.hrx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@ div {
@-webkit-keyframes {
from {
left: 0px;
10% {
whatever: hoo;
}
}
to {
left: 200px;
Expand Down Expand Up @@ -57,9 +54,6 @@ div:nth(-3) {
@-webkit-keyframes {
from {
left: 0px;
10% {
whatever: hoo;
}
}
to {
left: 200px;
Expand Down
Loading