Authenticator refactor (#486)

* Tidy sync flags.

* Tweak doc comments.

* Prune obsolete code.

* Remove NO_SYNC flag from authenticator.

* Support options in create_folder().

* Rename methods in VaultAccess.

* Tidy functions for flag access and doc comments.

* Support setting vault flags in VaultAccess.

* Respect SetVaultFlags event in folder reducer.

* Add test spec for set_vault_flags().

* Expose update_folder_flags() in Account.

* Support remove_local_folder().

To delete a folder, not apply the AccountEvent::DeleteFolder event to
the account logs so the folder will not be deleted from other devices
and the network implementation does not need to sync.

This is for folders which need special handling such as an authenticator
folder.

* Add initial NO_SYNC test spec.

* Test for is_sync_disabled() when building UpdateSet.

* Test for is_sync_disabled() when building sync diff.

* Add test spec for NO_SYNC flag.

* Bump patch version.

crates/integration_tests/tests/audit_trail/client.rs

@@ -158,7 +158,9 @@ async fn simulate_session(
     // Create a new folder
     let FolderCreate {
         folder: new_folder, ..
-    } = account.create_folder("New folder".to_string()).await?;
+    } = account
+        .create_folder("New folder".to_string(), Default::default())
+        .await?;
     // Rename the folder
     account
         .rename_folder(&new_folder, "New name".to_string())

crates/integration_tests/tests/diff_merge/folder_create.rs

@@ -45,7 +45,9 @@ async fn diff_merge_folder_create() -> Result<()> {
     // Create a new folder
     let FolderCreate {
         folder: summary, ..
-    } = local.create_folder("new_folder".to_owned()).await?;
+    } = local
+        .create_folder("new_folder".to_owned(), Default::default())
+        .await?;
 
     assert_ne!(local.sync_status().await?, remote.sync_status().await?);
 

crates/integration_tests/tests/diff_merge/folder_delete.rs

@@ -42,7 +42,9 @@ async fn diff_merge_folder_delete() -> Result<()> {
     // Create a new folder
     let FolderCreate {
         folder: summary, ..
-    } = local.create_folder("new_folder".to_owned()).await?;
+    } = local
+        .create_folder("new_folder".to_owned(), Default::default())
+        .await?;
 
     // Delete the folder
     local.delete_folder(&summary).await?;

crates/integration_tests/tests/diff_merge/folder_import.rs

@@ -52,7 +52,9 @@ async fn diff_merge_folder_import() -> Result<()> {
     temp.sign_in(&key).await?;
     let FolderCreate {
         folder: summary, ..
-    } = temp.create_folder("new_folder".to_owned()).await?;
+    } = temp
+        .create_folder("new_folder".to_owned(), Default::default())
+        .await?;
     let (folder_password, _) = generate_passphrase()?;
     let folder_key: AccessKey = folder_password.into();
     let exported = data_dir_export.join("exported.vault");

crates/integration_tests/tests/diff_merge/secret_move.rs

@@ -52,7 +52,9 @@ async fn diff_merge_secret_move() -> Result<()> {
     // Create a new folder
     let FolderCreate {
         folder: summary, ..
-    } = local.create_folder("new_folder".to_owned()).await?;
+    } = local
+        .create_folder("new_folder".to_owned(), Default::default())
+        .await?;
 
     // Move the secret
     let SecretMove { id: new_id, .. } = local

crates/integration_tests/tests/event_log/account_events.rs

@@ -33,8 +33,9 @@ async fn event_log_account() -> Result<()> {
     // Create a folder
     let commit = event_log.tree().last_commit();
     let folder_name = "folder_name";
-    let FolderCreate { folder, .. } =
-        account.create_folder(folder_name.to_string()).await?;
+    let FolderCreate { folder, .. } = account
+        .create_folder(folder_name.to_string(), Default::default())
+        .await?;
 
     let event = last_log_event(&mut event_log, commit.as_ref()).await?;
     assert!(matches!(event, Some(AccountEvent::CreateFolder(_, _))));

crates/integration_tests/tests/event_log/file_events.rs

@@ -29,8 +29,9 @@ async fn event_log_file() -> Result<()> {
 
     // Create a folder so we can move the secret
     let folder_name = "folder_name";
-    let FolderCreate { folder, .. } =
-        account.create_folder(folder_name.to_string()).await?;
+    let FolderCreate { folder, .. } = account
+        .create_folder(folder_name.to_string(), Default::default())
+        .await?;
 
     // Create an external file secret
     let (meta, secret, _file_path) = mock::file_text_secret()?;

crates/integration_tests/tests/file_transfers/abort_move.rs

@@ -26,7 +26,10 @@ async fn file_transfers_abort_move() -> Result<()> {
     let FolderCreate {
         folder: destination,
         ..
-    } = device.owner.create_folder("new_folder".to_owned()).await?;
+    } = device
+        .owner
+        .create_folder("new_folder".to_owned(), Default::default())
+        .await?;
 
     // Create an external file secret
     let (secret_id, _, _, file_name) =

crates/integration_tests/tests/file_transfers/attachments.rs

@@ -166,7 +166,10 @@ async fn file_transfers_attach_move() -> Result<()> {
     let FolderCreate {
         folder: destination,
         ..
-    } = device.owner.create_folder("new_folder".to_owned()).await?;
+    } = device
+        .owner
+        .create_folder("new_folder".to_owned(), Default::default())
+        .await?;
 
     // Moving the secret also needs to move the files
     let SecretMove { id: secret_id, .. } = device

crates/integration_tests/tests/file_transfers/late_upload.rs

@@ -47,7 +47,10 @@ async fn file_transfers_late_upload() -> Result<()> {
     let FolderCreate {
         folder: destination,
         ..
-    } = device.owner.create_folder("new_folder".to_owned()).await?;
+    } = device
+        .owner
+        .create_folder("new_folder".to_owned(), Default::default())
+        .await?;
     let SecretMove { id: secret_id, .. } = device
         .owner
         .move_secret(

crates/integration_tests/tests/file_transfers/multi_server.rs

@@ -143,7 +143,10 @@ async fn file_transfers_multi_move() -> Result<()> {
     let FolderCreate {
         folder: destination,
         ..
-    } = device.owner.create_folder("new_folder".to_owned()).await?;
+    } = device
+        .owner
+        .create_folder("new_folder".to_owned(), Default::default())
+        .await?;
 
     // Moving the secret also needs to move the file
     let SecretMove { id: secret_id, .. } = device

crates/integration_tests/tests/file_transfers/offline_multi.rs

@@ -192,7 +192,10 @@ async fn file_transfers_offline_multi_move() -> Result<()> {
     let FolderCreate {
         folder: destination,
         ..
-    } = device.owner.create_folder("new_folder".to_owned()).await?;
+    } = device
+        .owner
+        .create_folder("new_folder".to_owned(), Default::default())
+        .await?;
 
     // Moving the secret also needs to move the file
     let SecretMove { id: secret_id, .. } = device

crates/integration_tests/tests/file_transfers/single_server.rs

@@ -129,7 +129,10 @@ async fn file_transfers_single_move() -> Result<()> {
     let FolderCreate {
         folder: destination,
         ..
-    } = device.owner.create_folder("new_folder".to_owned()).await?;
+    } = device
+        .owner
+        .create_folder("new_folder".to_owned(), Default::default())
+        .await?;
 
     // Moving the secret also needs to move the file
     let SecretMove { id: secret_id, .. } = device

crates/integration_tests/tests/local_account/account_statistics.rs

@@ -204,8 +204,9 @@ async fn local_account_statistics() -> Result<()> {
 
     // Create a folder and add a secret to the folder
     let folder_name = "folder_name";
-    let FolderCreate { folder, .. } =
-        account.create_folder(folder_name.to_string()).await?;
+    let FolderCreate { folder, .. } = account
+        .create_folder(folder_name.to_string(), Default::default())
+        .await?;
     let (login_password, _) = generate_passphrase()?;
     let (mut meta, secret) = mock::login("login", TEST_ID, login_password);
     meta.set_favorite(true);

crates/integration_tests/tests/local_account/external_files.rs

@@ -292,7 +292,9 @@ async fn assert_move_file_secret(
     let FolderCreate {
         folder: destination,
         ..
-    } = account.create_folder(new_folder_name).await?;
+    } = account
+        .create_folder(new_folder_name, Default::default())
+        .await?;
 
     let SecretMove { id: new_id, .. } = account
         .move_secret(
@@ -400,7 +402,9 @@ async fn assert_create_update_move_file_secret(
     let FolderCreate {
         folder: destination,
         ..
-    } = account.create_folder(new_folder_name).await?;
+    } = account
+        .create_folder(new_folder_name, Default::default())
+        .await?;
 
     let (new_secret_data, _) = update_file_secret(
         account,

crates/integration_tests/tests/local_account/folder_lifecycle.rs

@@ -28,8 +28,9 @@ async fn local_folder_lifecycle() -> Result<()> {
 
     // Create a folder
     let folder_name = "folder_name";
-    let FolderCreate { folder, .. } =
-        account.create_folder(folder_name.to_string()).await?;
+    let FolderCreate { folder, .. } = account
+        .create_folder(folder_name.to_string(), Default::default())
+        .await?;
 
     // Open the new folder for writing
     account.open_folder(&folder).await?;

crates/integration_tests/tests/local_account/move_secret.rs

@@ -37,8 +37,9 @@ async fn local_move_secret() -> Result<()> {
 
     // Create a folder
     let folder_name = "folder_name";
-    let FolderCreate { folder, .. } =
-        account.create_folder(folder_name.to_string()).await?;
+    let FolderCreate { folder, .. } = account
+        .create_folder(folder_name.to_string(), Default::default())
+        .await?;
 
     // Move to the new folder
     account

crates/integration_tests/tests/local_account/search/view_query.rs

@@ -78,8 +78,9 @@ async fn local_search_view_query() -> Result<()> {
 
     // Create a folder and add secrets to the other folder
     let folder_name = "folder_name";
-    let FolderCreate { folder, .. } =
-        account.create_folder(folder_name.to_string()).await?;
+    let FolderCreate { folder, .. } = account
+        .create_folder(folder_name.to_string(), Default::default())
+        .await?;
 
     account.open_folder(&folder).await?;
     account.insert_secrets(new_folder_docs).await?;

crates/integration_tests/tests/network_account/listen_folder_create.rs

@@ -40,7 +40,7 @@ async fn network_sync_listen_folder_create() -> Result<()> {
         ..
     } = device1
         .owner
-        .create_folder("sync_folder".to_string())
+        .create_folder("sync_folder".to_string(), Default::default())
         .await?;
     assert!(sync_error.is_none());
 

crates/integration_tests/tests/network_account/listen_folder_delete.rs

@@ -31,7 +31,7 @@ async fn network_sync_listen_folder_delete() -> Result<()> {
         ..
     } = device1
         .owner
-        .create_folder("sync_folder".to_string())
+        .create_folder("sync_folder".to_string(), Default::default())
         .await?;
     assert!(sync_error.is_none());
 

crates/integration_tests/tests/network_account/listen_folder_import.rs

@@ -31,7 +31,7 @@ async fn network_sync_listen_folder_import() -> Result<()> {
         ..
     } = device1
         .owner
-        .create_folder("sync_folder".to_string())
+        .create_folder("sync_folder".to_string(), Default::default())
         .await?;
     assert!(sync_error.is_none());
 

crates/integration_tests/tests/network_account/main.rs

@@ -26,6 +26,8 @@ mod listen_multiple;
 mod multiple_remotes;
 mod multiple_remotes_fallback;
 
+mod no_sync;
+
 mod offline_manual;
 mod rename_account;
 mod server_definitions;