Improvements to Indexable trait
#494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add small docstring (still missing docstrings for the methods) - add required `size` method - add default implementation of `each_with_index` and `reverse_each_with_index` methods based on `size` and `[]!` methods - add `first!` and `last!` methods with default implementation based on `size` and `[]!` methods - refactor tests to ensure that pure `Indexable` implementations are tested correctly (rather than testing the overrides implemented by `Array`) - small compiler fix to ensure yield types of default implementations are traversed/resolved correctly
jemc
force-pushed
the
add/indexable-stuff
branch
from
e9836f7
to
1ee334c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sizemethodeach_with_indexandreverse_each_with_indexmethods based onsizeand[]!methodsfirst!andlast!methods with default implementation based onsizeand[]!methodsIndexableimplementations are tested correctly (rather than testing the overrides implemented byArray)