Fix invalid next track duration when track ends while buffering. #1074

CHANGES.md

@@ -5,6 +5,7 @@ Fixed:
 
 - Fixed exponential memory usage in clock unification algorithm (#1272).
 - Fixed rotate source order (#1279).
+- Fixed invalid new track duration in `crossfade` when track ends while buffering (#1074).
 
 1.4.2 (03-05-2020)
 =====

libs/fades.liq

@@ -281,8 +281,8 @@ def crossfade(~duration=5.,~override_duration="liq_cross_duration",
               ~default=(fun (a,b) -> sequence([a, b])),
               ~high=-15., ~medium=-32., ~margin=4.,
               ~minimum=(-1.),~width=2.,~conservative=true,s)
-  fade.out = fade.out(type="sin",duration=fade_out)
-  fade.in  = fade.in(type="sin",duration=fade_in)
+  fade.out = fade.final(type="sin",duration=fade_out)
+  fade.in  = fade.initial(type="sin",duration=fade_in)
   add = fun (a,b) -> add(normalize=false,[b, a])
   log = log(label="crossfade")
 

src/operators/cross.ml

@@ -336,7 +336,8 @@ class cross ~kind (s : source) ~cross_length ~override_duration ~rms_width
         self#save_last_metadata `After buf_frame;
         self#update_cross_length buf_frame start;
 
-        if not (AFrame.is_partial buf_frame) then begin
+        if AFrame.is_partial buf_frame then Generator.add_break gen_after
+        else begin
           self#slave_tick;
           if after_len < before_len then f ()
         end