Fix Array.fill call. Fixes: #3678

savonet · Jan 29, 2024 · 78a2ea5 · 78a2ea5
1 parent 5aa63d9
commit 78a2ea5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGES.md b/CHANGES.md
@@ -18,6 +18,7 @@ Fixed:
 - Make sure reconnection errors are router through the regulat `on_error` callback in `output.icecast` (#3635)
 - Fixed discontinuity count after a restart in HLS outputs.
 - Fixed memory leaks when using dynamically created sources (`input.harbor`, `input.ffmepg`, SRT sources and `request.dynamic`)
+- Fixed invalid array fill in `add` (#3678)
 
 ---
 

diff --git a/src/core/operators/add.ml b/src/core/operators/add.ml
@@ -147,7 +147,7 @@ class audio_add ~renorm ~power ~field tracks =
       assert (offset <= pos);
       let audio_offset = Frame.audio_of_main offset in
       let pcm = Content.Audio.get_data (Frame.get buf field) in
-      Audio.clear pcm audio_offset (Audio.length pcm);
+      Audio.clear pcm audio_offset (Audio.length pcm - audio_offset);
       List.iter
         (fun { source; fields } ->
           let tmp = self#track_frame source in