Make sure metadata.map does not mutate existing metadata.

savonet · Nov 3, 2023 · 93f305b · 93f305b
1 parent 80f1a91
commit 93f305b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/CHANGES.md b/CHANGES.md
@@ -21,6 +21,7 @@ Fixed:
   number of channels.
 - Improved support for unitary minus, fix runtime call of optional
   methods (#3498)
+- Fixed `map.metadata` mutating existing metadata.
 - Fixed reloading loop in playlists with invalid files (#3479)
 - Fixed main HLS playlist codecs when using `mpegts` (#3483)
 - Fixed pop/clicks in crossfade and source with caching (#3318)

diff --git a/src/core/operators/map_metadata.ml b/src/core/operators/map_metadata.ml
@@ -63,8 +63,10 @@ class map_metadata source rewrite_f insert_missing update strip =
       List.iter
         (fun (t, m) ->
           if t >= p then (
+            let m = Hashtbl.copy m in
             self#rewrite m;
-            if strip && Hashtbl.length m = 0 then Frame.free_metadata buf t))
+            if strip && Hashtbl.length m = 0 then Frame.free_metadata buf t
+            else Frame.set_metadata buf t m))
         (Frame.get_all_metadata buf)
   end