Log backtraces on two more errors. Refs: #3156

savonet · Jun 27, 2023 · e2c4e17 · e2c4e17
1 parent 1ee9b61
commit e2c4e17
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/src/core/outputs/icecast2.ml b/src/core/outputs/icecast2.ml
@@ -502,9 +502,11 @@ class output p =
                   ~charset:(Charset.to_string out_enc)
                   connection icy_meta
               with e ->
-                self#log#important
-                  "Metadata update may have failed with error: %s"
-                  (Printexc.to_string e))
+                let bt = Printexc.get_backtrace () in
+                Utils.log_exception ~log:self#log ~bt
+                  (Printf.sprintf
+                     "Metadata update may have failed with error: %s"
+                     (Printexc.to_string e)))
           | Cry.Disconnected -> ())
       else (
         (* Encoder is not always present.. *)

diff --git a/src/core/sources/harbor_input.ml b/src/core/sources/harbor_input.ml
@@ -105,8 +105,10 @@ class http_input_server ~pos ~transport ~dumpfile ~logfile ~bufferize ~max ~icy
                     in
                     f ()
                   with e ->
-                    self#log#severe "Error while reading from client: %s"
-                      (Printexc.to_string e);
+                    let bt = Printexc.get_backtrace () in
+                    Utils.log_exception ~log:self#log ~bt
+                      (Printf.sprintf "Error while reading from client: %s"
+                         (Printexc.to_string e));
                     self#disconnect ~lock:false;
                     0))
             buf len