Some Annotations Persist Between Track Changes

[BusterNeece]

Describe the bug

In our testing, we've discovered that, for the following annotations:

• liq_amplify
• liq_cross_duration
• liq_fade_in
• liq_fade_out

If one track sends along these annotations, they persist across multiple tracks until a new annotation comes in that resets the value.

The intended functionality in our case is that these values would only affect the specific track being annotated, and then would reset back to their default values immediately afterward.

Our temporary workaround is to always annotate a value for every single track, just annotating the default value for every track where the value isn't set, but of course this doesn't work if the thing that's set to play next isn't something we directly annotate via our "next song" call, i.e. a remote playlist or live DJ.

Expected behavior

It would be nice if there were either a system setting determining whether to persist these annotations across tracks or restore them to default after any metadata change. This could also be a configuration value on the actual functions that use those annotations (i.e. amplify, cross, etc).

Install method

Using 2.1.x branch Rolling Release via Debian package build in AzuraCast Rolling Release.

[toots]

Thanks for the report! liq_amplify was reseting at the end of a track as expected but the other ones were not. I just pushed some changes to 2.2.x implementing this by default. Since this is a change in behavior, this'll have to go out with this version as 2.1.x is not frozen. Thankfully, there is a workaround meanwhile.