Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

srt documentation and installation #2556

Closed
vitoyucepi opened this issue Aug 9, 2022 · 2 comments · Fixed by #2563
Closed

srt documentation and installation #2556

vitoyucepi opened this issue Aug 9, 2022 · 2 comments · Fixed by #2563
Assignees

Comments

@vitoyucepi
Copy link
Collaborator

Describe the bug
I tried to do some experiments with output.srt.
I think it has problems.

  1. Opam versions of conf-srt and srt are not maintained. They will fail to install on linux distros.
  2. output.srt(mode='listener') supports only one simultaneous connection.
  3. srt socket restarts after client disconnect.

To Reproduce
Run docker images

  • ocaml/opam:ubuntu-20.04-ocaml-4.14 - not fine
  • ocaml/opam:ubuntu-22.04-ocaml-4.14 - not fine
  • ocaml/opam:debian-10-ocaml-4.14 - not fine
  • ocaml/opam:debian-11-ocaml-4.14 - fine

With script

opam repository set-url default https://opam.ocaml.org/
sudo apt-get update
opam depext srt
opam install srt

Expected behavior

  1. I'd like to see documentation about

    In "listener" mode, it waits for clients to connect to it to send them the stream.

    I didn't expect that it will allow only one client at a time.

  2. srt with different distros.

Version details

  • OS: debian:10, debian:11, ubuntu:20.04, ubuntu:22.04
  • Version: 2.0.7, 2.1.0

Install method

  • opam
  • deb from release artifact

Common issues
N/A

@toots
Copy link
Member

toots commented Aug 14, 2022

Good points, thanks for raising them. The output operator was originally only considered for a single output and the listening code mostly comes from the input operator for which restarting the listening socket was an acceptable compromise. Will address both.

toots added a commit that referenced this issue Aug 16, 2022
toots added a commit that referenced this issue Aug 16, 2022
@toots toots self-assigned this Aug 16, 2022
@toots
Copy link
Member

toots commented Aug 16, 2022

The opam depext issues are addressed in ocaml/opam-repository#21987

toots added a commit that referenced this issue Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants