Cry improvements #107
Cry improvements #107
Conversation
|
Should be all good now. Review at will! |
|
Ha no, forgot chunked transfer.. |
|
Ready for review.. |
| 'http' for Icecast, 'icy' for shoutcast." ; | ||
| "verb", Lang.string_t, (Some (Lang.string "SOURCE")), | ||
| Some "Verb to use with the 'http' protocol. One of: \ | ||
| 'SOURCE', 'PUT' or 'POST'."; |
There was a problem hiding this comment.
Why not simply merge protocol and verb, ie protocol = source / put / post / icy and remove verb since icy is exclusive with the rest?
There was a problem hiding this comment.
Actually, I think it's better to keep the verb parameter seperate, to preserve backward-compatibility with the previous values for the protocol. Also, put and post verbs are quite experimental so I think it's good to leave it alone for now..
There was a problem hiding this comment.
I'm fine with this, it was just a quick idea...
|
I read the diff superficially and did not find anything obvious (but I did not test etc.) |
|
Indeed, why not.. ^^ |
|
I've tested |
This is to fix #82. It's still missing support for chunked and alternative verbs in harbor input.