Native avi support #256
Merged
Native avi support #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is nice and enables external for video too, see #233. For instance, we can encode avi with output.file(%external(process="ffmpeg -i pipe:0 -f avi pipe:1",video=true),"/tmp/test.mp4",s)
|
|
||
| let to_string w = | ||
| Printf.sprintf | ||
| "%%wav(samplerate=%d,channels=%d)" |
|
I did not test the feature at all but only had a quick look at the code. I found one typo and complained about whitespace. Other than that the changes seem completely backward compatible so as far as I'm concerned it's OK to merge. Thanks! |
smimram
added a commit
that referenced
this pull request
Aug 27, 2015
Native avi support. Allows for video in external encoder, closes #223.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is nice and enables external for video too, see #233. For instance, we can encode avi with