Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect functions defining the same label multiple times. #2823

Merged
merged 4 commits into from
Jan 4, 2023
Merged

Conversation

smimram
Copy link
Member

@smimram smimram commented Jan 3, 2023

This avoids situations such as #2819.

@smimram smimram requested a review from toots January 3, 2023 13:29
Copy link
Member

@toots toots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome thanks for doing this!

@toots toots merged commit f6ac06a into main Jan 4, 2023
@toots toots deleted the same-label branch January 4, 2023 10:46
@vitoyucepi
Copy link
Collaborator

Hi @toots,
There are also function annotations

# @param ~icy_id Shoutcast source ID. Only supported by Shoutcast v2.

# @param ~icy_id Shoutcast source ID. Only supported by Shoutcast v2.

How is website documentation generated?
https://www.liquidsoap.info/doc-dev/reference.html#output.shoutcast
https://www.liquidsoap.info/doc-2.1.3/reference.html#output.shoutcast

@toots
Copy link
Member

toots commented Jan 4, 2023

Hi @toots, There are also function annotations

# @param ~icy_id Shoutcast source ID. Only supported by Shoutcast v2.

# @param ~icy_id Shoutcast source ID. Only supported by Shoutcast v2.

How is website documentation generated? https://www.liquidsoap.info/doc-dev/reference.html#output.shoutcast https://www.liquidsoap.info/doc-2.1.3/reference.html#output.shoutcast

Thanks for pointing out, this is fixed now.

The doc is generated during the update webasite workflow that runs on each commit on the main branch: https://github.com/savonet/liquidsoap/actions/workflows/update-website.yml

The doc for released version is static and checked out in the https://github.com/savonet/liquidsoap-full repository (that will need to be broken up one day!).

@vitoyucepi
Copy link
Collaborator

The doc is generated during the update webasite workflow that runs on each commit on the main branch: https://github.com/savonet/liquidsoap/actions/workflows/update-website.yml

Oops, I'm sorry.
In my question, I want to point out that annotations could be inconsistent with the function definition.
BTW the documentation for 2.1.3 should be left as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants