Add TLS support! #3074
Merged
Add TLS support! #3074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toots
force-pushed
the
tls
branch
2 times, most recently
from
1b37413
to
021b417
Compare
toots
force-pushed
the
tls
branch
4 times, most recently
from
3ba6ddd
to
49dd666
Compare
toots
force-pushed
the
tls
branch
5 times, most recently
from
8d0dade
to
b576b26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for
ocaml-tlsnative SSL implementation! It uses a custom implementation of the abstract engine using blockingUnixcalls (kind of a shame they don't provide it!).The
secure_transportlayer is removed. It was always niche and the API is now deprecated in macos/ios.Worth noting: neither
secure_transportnotocaml-tlssupport private key password. This must be an uncommonly used feature. I had a test to confirm it works with SSL but it failed in the CI. It really doesn't make much sense to setup password for server-side things..