-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SRT I/O #898
Conversation
src/io/srt_io.ml
Outdated
|
||
"port", Lang.int_t, Some (Lang.int 8000), | ||
Some "Port to bind on the local machine (note: ports in SRT are \ | ||
not related to TCP ports.)"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is confusing, maybe it should be pointed out that these are UDP ports ? Wouldn't it be simplier to have bind_address like 0.0.0.0:8000 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll clarify. Here's what the doc says, which isn't very clear either:
The term "port" used in SRT is occasionally identical to the term "UDP port". However SRT offers more flexibility than UDP (or TCP, if we think about the more logical similarity) because it manages ports as its own resources. For example, one port may be shared between various services.
src/io/srt_io.ml
Outdated
Lang.add_operator "input.srt" | ||
~kind:(Lang.Unconstrained kind) | ||
~category:Lang.Input | ||
~descr:"Receive a SRT stream." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe be more precise in what this input is doing. Something like "Start a SRT agent in listener mode to receive and decode stream." ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Co-Authored-By: mbugeia <maxime.bugeia@gmail.com>
No description provided.