Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resample using ffmpeg. #947

Merged
merged 5 commits into from
Sep 10, 2019
Merged

Resample using ffmpeg. #947

merged 5 commits into from
Sep 10, 2019

Conversation

smimram
Copy link
Member

@smimram smimram commented Sep 2, 2019

Not tested yet, but should work pretty well :)

@smimram smimram added this to the 1.5.0 milestone Sep 2, 2019
@smimram smimram requested a review from toots September 2, 2019 15:51
@smimram smimram modified the milestones: 1.5.0, 1.4.0 Sep 9, 2019
@smimram
Copy link
Member Author

smimram commented Sep 9, 2019

This can be merged in my opinion. You can test with

set("log.level", 5)
set("audio.converter.samplerate.preferred", "ffmpeg")

s = playlist("~/Music")
s = mksafe(s)
s = stretch(ratio=1.2, s)
output.pulseaudio(s)

@toots
Copy link
Member

toots commented Sep 10, 2019

Look good to me, thanks!

@toots toots merged commit 53193a9 into master Sep 10, 2019
@toots toots deleted the ffmpeg-resample branch September 10, 2019 13:26
@smimram
Copy link
Member Author

smimram commented Sep 10, 2019

Thanks for merging! BTW, it seems to be better than samplerate with which we are secretly loosing some samples sometimes...

@toots
Copy link
Member

toots commented Sep 10, 2019

Ho wow. Wanna make it the default before samplerate when found?

@smimram
Copy link
Member Author

smimram commented Sep 10, 2019

I think it could be a good idea, yes. Where is the default chosen?

@toots
Copy link
Member

toots commented Sep 10, 2019

@smimram here: https://github.com/savonet/liquidsoap/blob/master/src/converters/audio_converter.ml#L55
You might want to switch this to an array like we do for decoders..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants