Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integrated with dev branch n tested email services #10

Merged
merged 5 commits into from
Sep 8, 2024
Merged

integrated with dev branch n tested email services #10

merged 5 commits into from
Sep 8, 2024

Conversation

Lee-Wei-Jie
Copy link
Collaborator

pulled dev branch into email service branch for testing. added minor changes:
-popup message content
-Fixed logout error page

@Lee-Wei-Jie
Updated:
f3abbfe 
-Logout Behaviour
-PW reset popup message
-Text for pw reset button
@Lee-Wei-Jie
Merge branch 'origin/develop/weijie/EmailService' of https://github.c…
062ca61 
…om/sayoungestguy/scaleup into origin/develop/weijie/EmailService
@Lee-Wei-Jie
Merge branch 'develop' of https://github.com/sayoungestguy/scaleup in…
798ac45 
…to origin/develop/weijie/EmailService
@Lee-Wei-Jie Lee-Wei-Jie self-assigned this Sep 7, 2024
sayoungestguy
sayoungestguy reviewed Sep 8, 2024
View reviewed changes
src/main/webapp/app/modules/login/logout.tsx
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this feature is stable, help to remove for future MR

sayoungestguy
sayoungestguy approved these changes Sep 8, 2024
View reviewed changes
Copy link
Owner

@sayoungestguy sayoungestguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Help to remove off the comment stuff and do npm run lint for future MR to resolve all the warnings.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Lee-Wei-Jie Lee-Wei-Jie merged commit 0cb9e71 into develop Sep 8, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayoungestguy sayoungestguy sayoungestguy approved these changes

@haikelthaqif haikelthaqif Awaiting requested review from haikelthaqif

@Sakthivel1103 Sakthivel1103 Awaiting requested review from Sakthivel1103

Assignees

@Lee-Wei-Jie Lee-Wei-Jie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lee-Wei-Jie @sayoungestguy