Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retain SystemId #659

Merged
merged 1 commit into from
May 25, 2023
Merged

Retain SystemId #659

merged 1 commit into from
May 25, 2023

Conversation

dubinsky
Copy link
Contributor

@dubinsky dubinsky commented Apr 2, 2023 •
edited
Loading

when systemId is known (file, URL), wrap InputSource around it instead of opening InputStream: this allows XInclude to work (XML parser will open the stream itself).

@dubinsky dubinsky marked this pull request as ready for review April 2, 2023 23:51
@dubinsky dubinsky changed the title Supply systemId - when it is known - in the InputSource, so that … XMLLoader returns Document Apr 3, 2023
@dubinsky dubinsky marked this pull request as draft April 3, 2023 22:29
@dubinsky dubinsky marked this pull request as ready for review April 4, 2023 06:27
@dubinsky
- when systemId is known (file, URL), wrap InputSource around it …
aac142a 
…instead of opening `InputStream`: this allows `XInclude` to work (XML parser will open the stream itself).
@dubinsky dubinsky changed the title XMLLoader returns Document Retain SystemId May 22, 2023
@dubinsky dubinsky merged commit 0ff5588 into scala:main May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SethTisue SethTisue SethTisue approved these changes

@ashawley ashawley Awaiting requested review from ashawley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dubinsky @SethTisue