Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad url link on dotty.epfl.ch/index.html #18444

Closed
iusildra opened this issue Aug 22, 2023 · 1 comment · Fixed by #18465
Closed

Bad url link on dotty.epfl.ch/index.html #18444

iusildra opened this issue Aug 22, 2023 · 1 comment · Fixed by #18465
Assignees
@Florian3k
Labels
area:doctool area:documentation itype:bug

Comments

@iusildra
Copy link
Contributor

Compiler version

Nightly build

Minimized code

image

There is a extra _doc/ in the url of Contributing link

Output

Nothing when clicking on the link

Expectation

Should throw an error, and redirect to https://dotty.epfl.ch/docs/contributing/index.html
@iusildra iusildra added itype:bug stat:needs triage Every issue needs to have an "area" and "itype" label labels Aug 22, 2023
@nicolasstucki
Copy link
Contributor

Duplicate of #18285

@nicolasstucki nicolasstucki marked this as a duplicate of #18285 Aug 24, 2023
@nicolasstucki nicolasstucki added area:documentation area:doctool and removed stat:needs triage Every issue needs to have an "area" and "itype" label labels Aug 24, 2023
@Florian3k Florian3k mentioned this issue Aug 28, 2023
Merged
@Florian3k Florian3k linked a pull request Aug 28, 2023 that will close this issue
Fix link resolving in scaladoc and fix invalid links in docs #18465
Merged
nicolasstucki added a commit that referenced this issue Aug 30, 2023
@nicolasstucki
Fix link resolving in scaladoc and fix invalid links in docs (#18465)
c58f9f6 
This PR combines #17099 changes with previous link resolver, which fixes
#18285, #18444 and brings down `Unable to resolve link` warnings from 81
to 7.
4 more links are fixed manually in `.md` files, which leaves us with 3
warnings.
Those 3 are references to source code inside `scaladoc.md`:

https://github.com/lampepfl/dotty/blob/45f633d0667c702fa75efcfda91b434bb72f04dc/docs/_docs/contributing/scaladoc.md?plain=1#L77-L87
Those won't work online anyway (unless we link to github), so we might
want change them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Florian3k Florian3k

Labels
area:doctool area:documentation itype:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix link resolving in scaladoc and fix invalid links in docs Florian3k/scala3
3 participants
@nicolasstucki @Florian3k @iusildra