Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the unwidened type when casting structural calls #18527

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Use the unwidened type when casting structural calls #18527

merged 3 commits into from
Oct 5, 2023

Conversation

dwijnand
Copy link
Member

@dwijnand dwijnand commented Sep 8, 2023

So if the call is to a stable val, the call will have a stable type.

@dwijnand
Use the unwidened type when casting structural calls
fd97de5 
So if the call is to a stable val, the call will have a stable type.
@dwijnand dwijnand linked an issue Sep 8, 2023 that may be closed by this pull request
find-member recursion #18263
Closed
@dwijnand dwijnand requested a review from sjrd September 29, 2023 08:35
@dwijnand dwijnand marked this pull request as ready for review September 29, 2023 08:35
@sjrd sjrd merged commit d788ef2 into scala:main Oct 5, 2023
18 checks passed
@soronpo
Copy link
Contributor

soronpo commented Oct 5, 2023

Thank you @dwijnand @sjrd for fixing this regression. I think this should be tagged for a 3.3.2 backport.

@sjrd sjrd added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Oct 5, 2023
@dwijnand dwijnand deleted the findMember-avoid-unstable-selectable branch October 5, 2023 16:20
@Kordyjan Kordyjan removed the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Oct 10, 2023
@dwijnand dwijnand mentioned this pull request Oct 18, 2023
Closed
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
@WojciechMazur WojciechMazur mentioned this pull request Jun 19, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jun 20, 2024
@WojciechMazur
Backport "Use the unwidened type when casting structural calls" to LTS (
71eba09 
#20640)

Backports #18527 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
@WojciechMazur WojciechMazur mentioned this pull request Jun 20, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jun 20, 2024
@WojciechMazur
Backport "Use the unwidened type when casting structural calls" to LTS (
c0a0dec 
#20693)

Backports #18527 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjrd sjrd sjrd approved these changes

Assignees

@sjrd sjrd

Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

find-member recursion
4 participants
@dwijnand @soronpo @sjrd @Kordyjan