Keep qualifier of Ident when selecting setter #18714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-18713
branch
2 times, most recently
from
5a1ed3b
to
c782372
Compare
odersky
requested changes
Nov 6, 2023
| @@ -1119,7 +1119,13 @@ class Typer(@constructorOnly nestingLevel: Int = 0) extends Namer | |||
| case Apply(fn, _) if fn.symbol.is(ExtensionMethod) => | |||
| def toSetter(fn: Tree): untpd.Tree = fn match | |||
| case fn @ Ident(name: TermName) => | |||
| untpd.cpy.Ident(fn)(name.setterName) | |||
| fn.tpe match | |||
There was a problem hiding this comment.
It looks non-sensical that on the one hand we can refer to a lhs with a simple ident, but on the other hand the setter needs a full tree expansion. Can you add a comment why that is so?
There was a problem hiding this comment.
Added a comment
nicolasstucki
force-pushed
the
fix-18713
branch
from
c782372
to
b682f68
Compare
We already keep the qualifier as a typed splice if the prefix is an explicit Select. Fixes scala#18713
nicolasstucki
force-pushed
the
fix-18713
branch
from
b682f68
to
789145c
Compare
odersky
approved these changes
Nov 13, 2023
WojciechMazur
added a commit
that referenced
this pull request
Jun 23, 2024
Backports #18714 to the LTS branch. PR submitted by the release tooling. [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already keep the qualifier as a typed splice if the prefix is an explicit Select.
Fixes #18713