Check @targetName when subtyping Refined Types #19081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamzaremmal
commented
Nov 25, 2023
tests/neg/i18922.check
Outdated
There was a problem hiding this comment.
I don't like this error message as it does not explain exactly why the types didn't match. We will have to add some custom message probably
sjrd
reviewed
Nov 29, 2023
Comment on lines
2087
to
2089
| (isSubInfo(info1, info2, m.symbol.info.orElse(info1)) && m.symbol.hasTargetName(m.symbol.name)) | ||
| || matchAbstractTypeMember(m.info) | ||
| || (tp1.isStable && m.symbol.isStableMember && isSubType(TermRef(tp1, m.symbol), tp2.refinedInfo)) |
There was a problem hiding this comment.
Why add the target name test only in the first of the three alternatives, and not in all of them? Couldn't we have the same issue in other cases?
sjrd
approved these changes
Nov 30, 2023
WojciechMazur
added a commit
that referenced
this pull request
Jun 26, 2024
) Backports #19081 to the LTS branch. PR submitted by the release tooling. [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18922