Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn about unchecked type tests in primitive catch cases #19206

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Warn about unchecked type tests in primitive catch cases #19206

merged 1 commit into from
Dec 9, 2023

Conversation

hamzaremmal
Copy link
Member

Closes #19013

hamzaremmal
hamzaremmal commented Dec 5, 2023
View reviewed changes
tests/neg/i4812.scala Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file should be moved to tests/warn

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is being done by another PR actually. See #18829

dwijnand
dwijnand reviewed Dec 6, 2023
View reviewed changes
tests/neg/i4812.check Outdated Show resolved Hide resolved
@hamzaremmal hamzaremmal merged commit fdd06ce into scala:main Dec 9, 2023
19 checks passed
@hamzaremmal hamzaremmal deleted the i19013 branch December 9, 2023 20:26
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
@WojciechMazur WojciechMazur mentioned this pull request Jun 25, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jun 26, 2024
@WojciechMazur
Backport "Warn about unchecked type tests in primitive catch cases" t…
faa5163 
…o LTS (#20794)

Backports #19206 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwijnand dwijnand dwijnand approved these changes

Assignees

@dwijnand dwijnand

Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

catch case fails to warn in case of unchecked bounded type parameter
3 participants
@hamzaremmal @dwijnand @Kordyjan