CC: Infer more self types automatically #19425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up the logic how we infer self types, and add a new clause:
> If we have an externally extensible class that itself does not have a
declared self types itself and also not in any of its base classes,
assume {cap} as the self type. Previously we would install a capture
set but then check after the fact that that capture set is indeed {cap}.
So it's less verbose to just assume that from the start.
They were causing cycles before. With the new policy these types don't need to be given explicitly anymore. I verified that the simple "Option" test now compiles. Fixes scala#19398
dwijnand
reviewed
Mar 6, 2024
| isOneOf(FinalOrSealed) || isClass && !isOneOf(EffectivelyOpenFlags) | ||
| isOneOf(FinalOrSealed) | ||
| || isClass && (!isOneOf(EffectivelyOpenFlags) | ||
| || isLocalToCompilationUnit) |
There was a problem hiding this comment.
The indentation suggests this should be an alternative to the line above, but the parentheses make it part of the previous.
@odersky is the indentation just wrong here, or are the parentheses wrong?
There was a problem hiding this comment.
Indentation looks wrong. Non-classes are never sealed.
There was a problem hiding this comment.
I am going to reformat as part of one of my next PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19398
Clean up the logic how we infer self types, and add a new clause: