chore: Backport changes from Metals #19592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rochala
reviewed
Feb 1, 2024
| ) | ||
| ) | ||
| val caseItems = | ||
| if res.isEmpty then completionGenerator.caseKeywordOnly |
There was a problem hiding this comment.
If I understand correctly, the case completion will only appear when there are no other candidates ? I think we can go one step further and make case keyword to always be added to the list. What do you think ?
There was a problem hiding this comment.
Here scalameta/metals#5346 (comment) we decided to only show case if there are no other completions
rochala
approved these changes
Feb 1, 2024
WojciechMazur
pushed a commit
that referenced
this pull request
Jun 28, 2024
backports scalameta/metals#5346 [Cherry-picked f15bbda]
WojciechMazur
pushed a commit
that referenced
this pull request
Jun 30, 2024
backports scalameta/metals#5346 [Cherry-picked f15bbda]
WojciechMazur
pushed a commit
that referenced
this pull request
Jun 30, 2024
backports scalameta/metals#5346 [Cherry-picked f15bbda]
WojciechMazur
pushed a commit
that referenced
this pull request
Jun 30, 2024
backports scalameta/metals#5346 [Cherry-picked f15bbda]
WojciechMazur
pushed a commit
that referenced
this pull request
Jun 30, 2024
backports scalameta/metals#5346 [Cherry-picked f15bbda]
WojciechMazur
pushed a commit
that referenced
this pull request
Jun 30, 2024
backports scalameta/metals#5346 [Cherry-picked f15bbda]
WojciechMazur
pushed a commit
that referenced
this pull request
Jun 30, 2024
backports scalameta/metals#5346 [Cherry-picked f15bbda]
WojciechMazur
added a commit
that referenced
this pull request
Jul 1, 2024
Backports #19592 to the LTS branch. PR submitted by the release tooling. [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backports scalameta/metals#5346