Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix module symbol recovery from NoClassDefFoundError #19645

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Fix module symbol recovery from NoClassDefFoundError #19645

merged 1 commit into from
Feb 8, 2024

Conversation

nicolasstucki
Copy link
Contributor

Fixes #19601

hamzaremmal
hamzaremmal reviewed Feb 8, 2024
View reviewed changes
compiler/src/dotty/tools/dotc/quoted/Interpreter.scala Outdated
if (sym.isDefinedInCurrentRun) Some(sym) else None
val className = message.replace('/', '.')
val sym =
if className.endsWith("$") then staticRef(className.toTermName).symbol.moduleClass
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if className.endsWith("$") then staticRef(className.toTermName).symbol.moduleClass
if className.endsWith(str.MODULE_SUFFIX) then staticRef(className.toTermName).symbol.moduleClass

@nicolasstucki nicolasstucki merged commit 7bcfce2 into scala:main Feb 8, 2024
16 checks passed
@nicolasstucki nicolasstucki deleted the fix-#19601 branch February 8, 2024 17:41
@nicolasstucki nicolasstucki mentioned this pull request Feb 14, 2024
Closed
@Kordyjan Kordyjan added this to the 3.4.1 milestone Feb 14, 2024
nicolasstucki added a commit to dotty-staging/dotty that referenced this pull request Mar 11, 2024
@nicolasstucki
Add regression test for scala#19909
2a97cb4 
Closes scala#19909

Probably fixed by scala#19645
@nicolasstucki nicolasstucki mentioned this pull request Mar 11, 2024
Merged
sjrd added a commit that referenced this pull request Mar 11, 2024
@sjrd
Add regression test for #19909 (#19915)
f6e4e65 
Closes #19909

Probably fixed by #19645
@WojciechMazur WojciechMazur mentioned this pull request Jun 28, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jul 1, 2024
@WojciechMazur
Backport "Fix module symbol recovery from NoClassDefFoundError" to …
6b44cc5 
…LTS (#20889)

Backports #19645 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
WojciechMazur pushed a commit that referenced this pull request Jul 2, 2024
@nicolasstucki @WojciechMazur
Add regression test for #19909
ffd8f5a 
Closes #19909

Probably fixed by #19645

[Cherry-picked 2a97cb4]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamzaremmal hamzaremmal hamzaremmal approved these changes

Assignees

@hamzaremmal hamzaremmal

Labels
None yet
Projects
None yet
Milestone
3.4.1
Development

Successfully merging this pull request may close these issues.

NoClassDefFoundError: while executing macro expansion
3 participants
@nicolasstucki @hamzaremmal @Kordyjan