Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak parameter accessor scheme #19719

Merged
merged 1 commit into from
Feb 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion compiler/src/dotty/tools/dotc/transform/PostTyper.scala
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,8 @@ class PostTyper extends MacroTransform with InfoTransformer { thisPhase =>
* This info is used in phase ParamForwarding
*/
private def forwardParamAccessors(impl: Template)(using Context): Unit = impl.parents match
case superCall @ Apply(fn, superArgs) :: _ if superArgs.nonEmpty =>
case superCall @ Apply(fn, superArgs) :: _
if superArgs.nonEmpty && fn.symbol.isPrimaryConstructor =>
fn.tpe.widen match
case MethodType(superParamNames) =>
for case stat: ValDef <- impl.body do
Expand Down
29 changes: 29 additions & 0 deletions tests/run/i19711.scala
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
class Foo(val s: Any):
def this(s: String) =
this(0)
class Bar(s: String) extends Foo(s):
def foo = s

class Foo2(val s: Any)
class Bar2(s: String) extends Foo2(s):
def foo = s

case class Config(_config: String)

abstract class Foo3(val config: Config) {
def this(config: String) = {
this(Config(config))
}
}

class Bar3(config: String) extends Foo3(config) {
def foo(): Unit = {
config.getClass()
}
}


@main def Test =
Bar("").foo
Bar2("").foo
Bar3("").foo()
Loading