Fix #19732: quotes.reflect.Ref incorrectly casting This to RefTree
#19930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
approved these changes
Mar 14, 2024
|
will this be backported to 3.3.x LTS? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the issue minimisation,
tpd.refreturns a tpd.This(Ident(Inner$)) tree, where the inner ident is a type ident, which was unexpected. Trying to adjust thetpd.refto return a RefType for that case seems dangerous, so I instead opted for a workaround directly inside the QuotesImpl.At first I wanted to reuse the
tpd.Thistree somehow (or at least to use a correctly retypedIdent), but nothing I tried with it worked, so I ended up writing the correct Ref by hand.Fixes #19732