Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow implicit conversions on prefixes of type selections #19934

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Mar 12, 2024

Fixes #19888

@odersky odersky requested a review from sjrd March 13, 2024 10:52
@odersky odersky requested review from noti0na1 and removed request for sjrd March 13, 2024 10:53
Copy link
Member

@noti0na1 noti0na1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix in this PR may hide some illegal type selections.

tests/neg/i11994.check Show resolved Hide resolved
tests/neg/i11994.check Outdated Show resolved Hide resolved
@noti0na1 noti0na1 assigned odersky and unassigned noti0na1 Mar 13, 2024
There was a val that escaped before, which caused cyclic references raised
during importSuggestions to be reported instead of being ignored.
@odersky odersky assigned noti0na1 and unassigned odersky Mar 13, 2024
Copy link
Member

@noti0na1 noti0na1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@odersky odersky merged commit 3d5cf9c into scala:main Mar 14, 2024
19 checks passed
@odersky odersky deleted the fix-19888 branch March 14, 2024 12:33
@Kordyjan Kordyjan added this to the 3.4.2 milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implicit conversions can add extension type members
3 participants