Extra check to avoid converting block expressions on the rhs of an in…

[LucySMartin]

…fix expression.

Tests added for:

• Original cast as per the ticket should not be changed
• Similar match statement that should update
• Code blocks in this position, as opposed to a partial function, cant update here
• Simple change that should apply but in a code position where the op stack is nonempty
• Equivalent code, but passing in the partial function as a single parameter, again, not updating

Fixes #20002

[som-snytt]

Does the fixes link need to be in the OP comment? I don't see the ticket saying may be fixed by.

[hamzaremmal]

Thank you for your collaboration to Scala 3. The main issue of this ticket is that at the moment, we rewrite when we have braces after a symbolic operator. The syntax doesn't allow us to have an indented block in this case. For this PR, I would expect at least the following test to work:

• No rewrite:

Reactions += {
  partialFunction
}

• Should rewrite (because the operator is not symbolic):

infix def run(f: PartialFunction[Int, Unit]) = ???
    
Reactions run {
  case 0 => ???
}

[LucySMartin]

Thank you for your collaboration to Scala 3. The main issue of this ticket is that at the moment, we rewrite when we have braces after a symbolic operator. The syntax doesn't allow us to have an indented block in this case. For this PR, I would expect at least the following test to work:

• No rewrite:

Reactions += {
  partialFunction
}

• Should rewrite (because the operator is not symbolic):

infix def run(f: PartialFunction[Int, Unit]) = ???
    
Reactions run {
  case 0 => ???
}

Oh!
Yep - thats a thing.
My professional roll we use brackets everywhere, thats not a place I knew you could ignore them.
Ill look into that in some more detail this evening.

[hamzaremmal]

LGTM

[hamzaremmal]

@LucySMartin Can you squash your commits before I merge it ? Thanks

[LucySMartin]

@hamzaremmal Squashed. Do you also want a rebase or no?

[sjrd]

Rebasing is not necessary unless there are conflicts.

[hamzaremmal]

@hamzaremmal Squashed. Do you also want a rebase or no?

As @sjrd mentioned, there is no need.