Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport "fix(#16458): regression in xml syntax parsing" to LTS #20920

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Backport "fix(#16458): regression in xml syntax parsing" to LTS #20920

merged 3 commits into from
Jul 2, 2024

Commits on Jul 2, 2024

  1. fix(#16458): regression in xml syntax parsing 

    xLiteral mistakenly assumed that the element just after `<` is always
non-special element, but it is not true. It could be xCharData, comment,
xProcInstr.

[Cherry-picked 77aa363]
    @i10416 @WojciechMazur
    i10416 authored and WojciechMazur committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    4be0636 View commit details
    Browse the repository at this point in the history

  2. improve: just use content_LT to fix 16458 

    Just replacing element with content_LT, it works.

See #19522 (comment)

[Cherry-picked 27046fe]
    @i10416 @WojciechMazur
    i10416 authored and WojciechMazur committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    42941b0 View commit details
    Browse the repository at this point in the history

  3. tidy: use run test instead of compile test 

    To check parsing properly, it is better to run a test and assert parse
result.

[Cherry-picked 9de9d57]
    @i10416 @WojciechMazur
    i10416 authored and WojciechMazur committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    8bcdcc7 View commit details
    Browse the repository at this point in the history