Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport "Bring back ambiguity filter when we report an implicit not found error" to LTS #21103

Merged
merged 2 commits into from
Jul 6, 2024
Merged

Backport "Bring back ambiguity filter when we report an implicit not found error" to LTS #21103

merged 2 commits into from
Jul 6, 2024

Conversation

WojciechMazur
Copy link
Contributor

Backports #20368 to the LTS branch.

PR submitted by the release tooling.
[skip ci]

@odersky @WojciechMazur
Bring back ambiguity filter when we report an implicit not found error
d33a968 
This reverts one part of #20261. When we fail with both an ambiguity on one implicit argument and another error on another argument we prefer the other error. I added a comment why this is needed.

Fixes #20344

[Cherry-picked 863077c]
@odersky @WojciechMazur
Update compiler/src/dotty/tools/dotc/typer/Typer.scala
1ee9297 
Co-authored-by: Matt Bovel <matthieu@bovel.net>
[Cherry-picked 783b7bd]
Base automatically changed from lts-20311 to lts-3.3 July 6, 2024 21:54
@WojciechMazur
Copy link
Contributor Author

No regressions detected in the community build up to lts-20279.

Reference

@WojciechMazur WojciechMazur merged commit 6ff12a3 into lts-3.3 Jul 6, 2024
19 checks passed
@WojciechMazur WojciechMazur deleted the lts-20368 branch July 6, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WojciechMazur @odersky