Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport "Report only non-overridden unimplemented members" to 3.5.2 #21484

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Backport "Report only non-overridden unimplemented members" to 3.5.2 #21484

merged 1 commit into from
Aug 28, 2024

Commits on Aug 28, 2024

  1. Report only non-overridden unimplemented members 

    Previously, when a concrete class A had unimplemented members that are
overridden, all overrides would be reported as unimplemented in the
error message. This would produce error messages that are not accurate,
and that suggest stubs that are not correct.

This patch fixes the issue by reporting in the error message only the
unimplemented members that are not overridden by other unimplemented
members.

Fixes #21335

[Cherry-picked 0d50a30]
    @Duhemm @WojciechMazur
    Duhemm authored and WojciechMazur committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    cc37466 View commit details
    Browse the repository at this point in the history