Fix incorrect caching with dependent method parameters #21699
+29
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
added
the
backport:nominated
smarter
changed the title
smarter
changed the title
smarter
force-pushed
the
fix-isProvisional
branch
from
891e04d
to
a09b8a3
Compare
smarter
force-pushed
the
fix-isProvisional
branch
from
a09b8a3
to
972a39b
Compare
The added test case used to fail Ycheck:typer with the seemingly identicals:
Found: (a: (aa : A{type B = Int}), b: a.B): CCPoly[(aa : A{type B = Int})]
Required: (a: (aa : A{type B = Int}), b: a.B): CCPoly[(aa : A{type B = Int})]
In fact one of the `aa` is a a TypeVar instantiated to `A {type B = Int }`. The
MethodType comparison failed the signature check because the `a.B` where `a` is
backed by a type variable had a stale signature cached.
Fixed by changing `isProvisional` to traverse ParamRefs.
smarter
force-pushed
the
fix-isProvisional
branch
from
972a39b
to
c32e535
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The added test case used to fail Ycheck:typer with the seemingly identicals:
In fact one of the
aais a a TypeVar instantiated toA {type B = Int }. The MethodType comparison failed the signature check because thea.Bwhereais backed by a type variable had a stale signature cached.Fixed by changing
isProvisionalto traverse ParamRefs.