Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScalafmtReflect: lazily load obsolete class #3690

Merged
merged 2 commits into from
Nov 12, 2023

Conversation

kitbellew
Copy link
Collaborator

Also, restore that same class in the repository so older versions of the dynamic ScalafmtReflect will continue functioning even if they won't be using the class. Helps with #3689.

Also, restore that same class in the repository so older versions of the
dynamic ScalafmtReflect will continue functioning even if they won't be
using the class.
@kitbellew
Copy link
Collaborator Author

after the first commit, test start failing with the same errors as what everyone has seen (corrupted class path etc.); not because of the contents of the commit (running the tests as of the release triggers that) but just to separate from the second commit which introduces the fix.

@kitbellew kitbellew merged commit 75669c3 into scalameta:master Nov 12, 2023
9 checks passed
@kitbellew kitbellew deleted the 3689_1 branch November 12, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant