Improvement/zenko 4871 readonly for pra #2132

KillianG · 2024-08-28T11:44:44Z

No description provided.

bert-e · 2024-08-28T11:44:47Z

Hello killiang,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

tests/ctst/steps/pra.ts

Issue: ZENKO-4871

bert-e · 2024-09-02T08:32:24Z

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

KillianG · 2024-09-02T08:32:38Z

/create_integration_branches

bert-e · 2024-09-02T08:32:48Z

History mismatch

Merge commit #4c2ee0add1d3f605ada5da7355232ecc183088c2 on the integration branch
w/2.7/improvement/ZENKO-4871-readonly-for-pra is merging a branch which is neither the current
branch improvement/ZENKO-4871-readonly-for-pra nor the development branch
development/2.7.

It is likely due to a rebase of the branch improvement/ZENKO-4871-readonly-for-pra and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

The following options are set: create_integration_branches

KillianG · 2024-09-02T08:32:55Z

/reset

bert-e · 2024-09-02T08:33:04Z

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: create_integration_branches

bert-e · 2024-09-02T08:39:32Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

The following options are set: create_integration_branches

tests/ctst/features/pra.feature

tests/ctst/steps/pra.ts

.github/scripts/end2end/deploy-zenko.sh

tests/ctst/steps/pra.ts

.github/scripts/end2end/configs/zenko.yaml

.github/workflows/end2end.yaml

solution/deps.yaml

bert-e · 2024-09-05T07:58:45Z

History mismatch

Merge commit #856eed78e9e978c9bb8fbe87db545e219c8d3af7 on the integration branch
w/2.7/improvement/ZENKO-4871-readonly-for-pra is merging a branch which is neither the current
branch improvement/ZENKO-4871-readonly-for-pra nor the development branch
development/2.7.

It is likely due to a rebase of the branch improvement/ZENKO-4871-readonly-for-pra and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

The following options are set: create_integration_branches

Issue: ZENKO-4871

KillianG · 2024-09-05T08:00:54Z

/reset

bert-e · 2024-09-05T08:01:04Z

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: create_integration_branches

bert-e · 2024-09-05T08:03:06Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

The following options are set: create_integration_branches

Issue: ZENKO-4871

williamlardier

lgtm (I know we have flakies, but unrelated to these changes...)

Issue: ZENKO-4871

…ting Issue: ZENKO-4871

Issue: ZENKO-4871

tests/ctst/steps/cronjobs/countItems.ts

KillianG · 2024-09-05T19:46:02Z

/approve

As the data accessor is seeded by vault's cronjob, it might take some time to be processed by kafka, so accessing it directly won't work. Issue: ZENKO-4871

Issue: ZENKO-4871

bert-e · 2024-09-06T14:30:45Z

Build failed

The build for commit did not succeed in branch w/2.7/improvement/ZENKO-4871-readonly-for-pra.

The following options are set: approve, create_integration_branches

KillianG requested review from francoisferrand, williamlardier, Kerkesni and benzekrimaha and removed request for francoisferrand August 28, 2024 11:52

scality deleted a comment from bert-e Aug 28, 2024

KillianG force-pushed the improvement/ZENKO-4871-readonly-for-pra branch from fe84799 to ce537bb Compare August 30, 2024 07:57

KillianG changed the base branch from development/2.6 to improvement/ZENKO-4868-restore-on-dr-site August 30, 2024 07:58

williamlardier reviewed Aug 30, 2024

View reviewed changes

tests/ctst/steps/pra.ts Outdated Show resolved Hide resolved

tests/ctst/steps/pra.ts Outdated Show resolved Hide resolved

KillianG added 3 commits September 2, 2024 10:23

Test readonly on DR site

d80321e

Issue: ZENKO-4871

Test with assume role with web identity for data accessor

3bb2557

Issue: ZENKO-4871

Precise that the put object should be rejected for DATA_ACCESSOR

f427570

Issue: ZENKO-4871

KillianG force-pushed the improvement/ZENKO-4871-readonly-for-pra branch from 66d3fb9 to f427570 Compare September 2, 2024 08:24

scality deleted a comment from bert-e Sep 2, 2024

KillianG changed the base branch from improvement/ZENKO-4868-restore-on-dr-site to development/2.6 September 2, 2024 08:32

scality deleted a comment from bert-e Sep 2, 2024

KillianG requested a review from williamlardier September 2, 2024 12:20

williamlardier reviewed Sep 2, 2024

View reviewed changes

tests/ctst/features/pra.feature Outdated Show resolved Hide resolved

tests/ctst/steps/pra.ts Outdated Show resolved Hide resolved

tests/ctst/steps/pra.ts Outdated Show resolved Hide resolved

francoisferrand reviewed Sep 3, 2024

View reviewed changes

.github/scripts/end2end/deploy-zenko.sh Outdated Show resolved Hide resolved

francoisferrand reviewed Sep 3, 2024

View reviewed changes

tests/ctst/steps/pra.ts Outdated Show resolved Hide resolved

francoisferrand reviewed Sep 5, 2024

View reviewed changes

.github/scripts/end2end/configs/zenko.yaml Outdated Show resolved Hide resolved

francoisferrand reviewed Sep 5, 2024

View reviewed changes

.github/workflows/end2end.yaml Outdated Show resolved Hide resolved

francoisferrand reviewed Sep 5, 2024

View reviewed changes

solution/deps.yaml Outdated Show resolved Hide resolved

KillianG force-pushed the improvement/ZENKO-4871-readonly-for-pra branch from a618403 to f427570 Compare September 5, 2024 07:58

Remove useless annotation

5af4461

Issue: ZENKO-4871

scality deleted a comment from bert-e Sep 5, 2024

Add base for annotation

4321716

Issue: ZENKO-4871

KillianG requested review from williamlardier and francoisferrand September 5, 2024 10:14

williamlardier approved these changes Sep 5, 2024

View reviewed changes

KillianG added 5 commits September 5, 2024 14:36

Slightly increase kfkc interval to make dr on restore work

2ac5af6

Issue: ZENKO-4871

Change step position for readonly check to gain some delay before tes…

0b93d24

…ting Issue: ZENKO-4871

Launch ensure vault seed job to be sure data accessor role is created

17c02e7

Issue: ZENKO-4871

Fix lint issue

3eed178

Issue: ZENKO-4871

chore: Update step position for readonly check to delay testing

a198cd1

Issue: ZENKO-4871

francoisferrand reviewed Sep 5, 2024

View reviewed changes

tests/ctst/steps/cronjobs/countItems.ts Outdated Show resolved Hide resolved

francoisferrand approved these changes Sep 5, 2024

View reviewed changes

williamlardier added 2 commits September 6, 2024 13:48

Ensure data accessor is propagated in DR site

63cee3b

As the data accessor is seeded by vault's cronjob, it might take some time to be processed by kafka, so accessing it directly won't work. Issue: ZENKO-4871

Generalize cronjob step logic

fb5da6e

Issue: ZENKO-4871

scality deleted a comment from KillianG Sep 6, 2024

bert-e closed this pull request by merging all changes into development/2.6 in cf0fa9d Sep 7, 2024

bert-e deleted the improvement/ZENKO-4871-readonly-for-pra branch September 7, 2024 08:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improvement/zenko 4871 readonly for pra #2132

Improvement/zenko 4871 readonly for pra #2132

KillianG commented Aug 28, 2024

bert-e commented Aug 28, 2024

bert-e commented Sep 2, 2024

KillianG commented Sep 2, 2024

bert-e commented Sep 2, 2024

KillianG commented Sep 2, 2024

bert-e commented Sep 2, 2024

bert-e commented Sep 2, 2024

bert-e commented Sep 5, 2024

KillianG commented Sep 5, 2024

bert-e commented Sep 5, 2024

bert-e commented Sep 5, 2024

williamlardier left a comment

KillianG commented Sep 5, 2024

bert-e commented Sep 6, 2024

Improvement/zenko 4871 readonly for pra #2132

Improvement/zenko 4871 readonly for pra #2132

Conversation

KillianG commented Aug 28, 2024

bert-e commented Aug 28, 2024

Hello killiang,

bert-e commented Sep 2, 2024

Request integration branches

KillianG commented Sep 2, 2024

bert-e commented Sep 2, 2024

History mismatch

KillianG commented Sep 2, 2024

bert-e commented Sep 2, 2024

Reset complete

bert-e commented Sep 2, 2024

Waiting for approval

bert-e commented Sep 5, 2024

History mismatch

KillianG commented Sep 5, 2024

bert-e commented Sep 5, 2024

Reset complete

bert-e commented Sep 5, 2024

Waiting for approval

williamlardier left a comment

Choose a reason for hiding this comment

KillianG commented Sep 5, 2024

bert-e commented Sep 6, 2024

Build failed