Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConvexPolyhedron calculateWorldAABB() can return undefined values in max #360

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jfaust
Copy link

@jfaust jfaust commented Feb 12, 2018

I ran into a situation where the AABB of a Body I was creating had a NaN value in its calculated AABB. Turns out, if a ConvexPolyhedron has vertices where one or more components are always decreasing, the
AABB calculation had a bug where the max[x|y|z] values would remain undefined. This PR fixes the bug and adds a unit test for it.

robrohan added a commit to TheRohans/dapao that referenced this pull request Oct 14, 2018
stockhuman added a commit to pmndrs/cannon-es that referenced this pull request Mar 7, 2020
yaustar pushed a commit to yaustar/cannon.js that referenced this pull request May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant