Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Ransack from collection model; use new component instead for table header links. #2744

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Remove Ransack from collection model; use new component instead for table header links. #2744

wants to merge 18 commits into from

Commits on Sep 11, 2024

  1. use a new SortedTableHeaderLinkCreator service to replace ransack fro… 

    …m the collection model
    @eddierubeiz
    eddierubeiz committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    803a82c View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. component instead of service

    @eddierubeiz
    eddierubeiz committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    6b99bb7 View commit details
    Browse the repository at this point in the history

  2. remove template and add call method instead

    @eddierubeiz
    eddierubeiz committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    f1ec1aa View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. dryer setup in the controller

    @eddierubeiz
    eddierubeiz committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    4aab61e View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. better documented, and index method now uses permitted params

    @eddierubeiz
    eddierubeiz committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    6343cdb View commit details
    Browse the repository at this point in the history

  2. simplify handling of extra params

    @eddierubeiz
    eddierubeiz committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    ce8410e View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. adding button as permitted param

    @eddierubeiz
    eddierubeiz committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    167b9c9 View commit details
    Browse the repository at this point in the history

  2. remove extra space in title

    @eddierubeiz
    eddierubeiz committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    d0aad79 View commit details
    Browse the repository at this point in the history

  3. adding a test

    @eddierubeiz
    eddierubeiz committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    7df1819 View commit details
    Browse the repository at this point in the history

  4. add test for actual link title

    @eddierubeiz
    eddierubeiz committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    59cefbf View commit details
    Browse the repository at this point in the history

  5. remove irksome button hash key

    @eddierubeiz
    eddierubeiz committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    47ad183 View commit details
    Browse the repository at this point in the history

  6. don't short-circuit collection_params, just call index_params where a… 

    …ppropriate
    @eddierubeiz
    eddierubeiz committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    31a1988 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. moving button deletion to #index

    @eddierubeiz
    eddierubeiz committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    63cc244 View commit details
    Browse the repository at this point in the history

  2. adding hidden fields for sort_field and sort_order, so search order i… 

    …s preserved
    @eddierubeiz
    eddierubeiz committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    c036919 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into remove_ransack_from_collections

    @eddierubeiz
    eddierubeiz committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    d8962e8 View commit details
    Browse the repository at this point in the history

  4. allow arbitrary keys for sort key and direction 

    slight change to how we handle sort order
    @eddierubeiz
    eddierubeiz committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    00ced0a View commit details
    Browse the repository at this point in the history

  5. restore ransack behavior of which order when changing sort field

    @jrochkind
    jrochkind committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    c3e7363 View commit details
    Browse the repository at this point in the history

  6. Merge pull request #2753 from sciencehistory/restore_ransack_behavior 

    restore ransack behavior of which order when changing sort field
    @eddierubeiz
    eddierubeiz committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    aa6fb29 View commit details
    Browse the repository at this point in the history