Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whole-work download uses original PDF instead of constructed PDF where appropriate #2747

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Whole-work download uses original PDF instead of constructed PDF where appropriate #2747

wants to merge 7 commits into from

Conversation

jrochkind
Copy link
Contributor

On top of #2746

  • DownloadOption now has content_type to effect display
  • DownloadOption@dup_with properly pass on content_type
  • WorkDownloadLinksComponent uses DownloadOption#content_type to determine icon and wording
  • whole-work downloads can include original PDF instead of constructed PDF

Base automatically changed from download_dropdown_refactor to master September 17, 2024 20:31
@jrochkind jrochkind marked this pull request as ready for review September 18, 2024 19:10
@jrochkind jrochkind mentioned this pull request Sep 18, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jrochkind