Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post about pypalettes #226

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

JosephBARBIERDARNAL
Copy link

@JosephBARBIERDARNAL JosephBARBIERDARNAL commented Jul 4, 2024

  • PyPalettes is a python library built on top of matplotlib that provides more than 2500 palettes, a simple API for using them and web app to browse/preview them.

  • The main subject relates to at least one project affiliated to the Scientific Python Ecosystem: Matplotlib

  • I have the right to publish the content under BSD 3-Clause License for the code and Creative Common CC-BY-4.0 License for the text.

  • Images have been compressed using a tool like pngquant

@JosephBARBIERDARNAL
Copy link
Author

JosephBARBIERDARNAL commented Jul 4, 2024

Hello!

I haven't been able to preview my post when running the site locally.

Everything seems to work fine (able to see the posts at http://localhost:1313/tags/matplotlib/).

Did I miss a step?

Thanks

EDIT: solution found (:

PS: still a draft at the moment I'm writing this

Copy link
Member

@stefanv stefanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JosephBARBIERDARNAL, this is a great start! Do you perhaps want to write a bit more, eg explaining how the project came about, where you got the colors from, who the target audiences are, give code examples of how to use it, etc?

EDIT: I see it's a draft; I'll update the PR status.

content/posts/matplotlib/pypalettes/index.md Outdated Show resolved Hide resolved
@stefanv stefanv marked this pull request as draft July 4, 2024 16:27
JosephBARBIERDARNAL and others added 2 commits July 5, 2024 09:08
Co-authored-by: Stefan van der Walt <sjvdwalt@gmail.com>
@stefanv
Copy link
Member

stefanv commented Jul 5, 2024

See licensing comments made on bcb4eea

@JosephBARBIERDARNAL JosephBARBIERDARNAL marked this pull request as ready for review July 8, 2024 14:28
@JosephBARBIERDARNAL
Copy link
Author

This PR can be merged! I'm perfectly open to feedback if any changes are necessary.

I've also made the changes related to the licensing issue.

@JosephBARBIERDARNAL
Copy link
Author

Hey @stefanv ! I'm taking the liberty of sending you a ping to tell you that this PR can be merged (:

I've made the changes related to the licensing issue

@stefanv
Copy link
Member

stefanv commented Sep 9, 2024

I am still not very comfortable with scraping another package's data, and presenting it as a new package. There is no mention of R paletteer outside of the license file.

Perhaps safest would be to ask whether @EmilHvitfeldt is OK with this type of usage, and hear what concerns they might have.

@JosephBARBIERDARNAL
Copy link
Author

I'm not sure I understand. Scraping is only used for technical simplicity and paletteer is obviously also mentioned in the documentation acknowledgements (see https://github.com/JosephBARBIERDARNAL/pypalettes?tab=readme-ov-file#acknowledgements).

@stefanv
Copy link
Member

stefanv commented Sep 9, 2024

I see the mention now, thanks for pointing it out. Still, I think best to get the thumbs-up from those who did the original work to aggregate all this data.

@JosephBARBIERDARNAL
Copy link
Author

Yes, I can understand that. I'll add an explicit mention at the top of the README.

@EmilHvitfeldt
Copy link

I approve! if you need approval elsewhere please ping me

@stefanv
Copy link
Member

stefanv commented Sep 9, 2024

Thanks, Emil!

@JosephBARBIERDARNAL
Copy link
Author

Thanks to both of you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants