Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof of concept of SVG icons next to external header links #163

Merged
merged 2 commits into from
Mar 22, 2022

Conversation

stefanv
Copy link
Member

@stefanv stefanv commented Mar 22, 2022

Will necessitate updating blog navigation partial as well (I should fix that in the theme, so that the blog can re-use the navbar from here).

  • Remove external_link from Features; it's just to show how it works

@netlify
Copy link

netlify bot commented Mar 22, 2022

✅ Deploy Preview for scientific-python-hugo-theme ready!

🔨 Explore the source changes: 772e80c

🔍 Inspect the deploy log: https://app.netlify.com/sites/scientific-python-hugo-theme/deploys/62396b2abd85b10008331e4b

😎 Browse the preview: https://deploy-preview-163--scientific-python-hugo-theme.netlify.app

@jarrodmillman jarrodmillman self-requested a review March 22, 2022 14:39
@jarrodmillman jarrodmillman marked this pull request as draft March 22, 2022 14:40
@jarrodmillman jarrodmillman marked this pull request as ready for review March 22, 2022 16:27
@jarrodmillman
Copy link
Member

I am merging this with the example external link for now. I will make an issue and follow-up PR to remove it and document the feature.

@jarrodmillman jarrodmillman merged commit b147a37 into scientific-python:main Mar 22, 2022
alphapapa added a commit to alphapapa/scientific-python-hugo-theme that referenced this pull request Sep 27, 2023
…cientific-python#163)"

This reverts commit b147a37.

See discussion starting at
<scientific-python#233 (comment)>.

This feature may be reintroduced and documented later.
jarrodmillman pushed a commit that referenced this pull request Sep 27, 2023
…163)" (#269)

This reverts commit b147a37.

See discussion starting at
<#233 (comment)>.

This feature may be reintroduced and documented later.
@jarrodmillman jarrodmillman added this to the 0.1 milestone Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants