Remove panel underline of button #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for scientific-python-hugo-theme ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
tupui
reviewed
Mar 24, 2022
jarrodmillman
force-pushed
the
panel-nounderlinewq
branch
from
e2dee93
to
7bc10e4
Compare
|
@tupui This should work. |
|
As discussed, I will take over this PR. |
jarrodmillman
commented
Mar 24, 2022
assets/theme-css/panel.css
Outdated
| border-radius: 3px; | ||
| box-shadow: 0px 8px 15px var(--colorShadow); |
There was a problem hiding this comment.
I added it when I removed the panel-underline thing. Now that it is back, I don't think this is needed.
|
I tested this on both learn and blog and it LGTM! I made one comment regarding removing one line that I don't think is necessary. |
tupui
reviewed
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.