Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Project icon positioning (#261) #265

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

alphapapa
Copy link
Contributor

This moves the project icon to appear like a superscript. See #261.

Screen Shot 2023-09-25 at 22 00 16

@alphapapa alphapapa self-assigned this Sep 26, 2023
@netlify
Copy link

netlify bot commented Sep 26, 2023

Deploy Preview for scientific-python-hugo-theme ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e71122a
🔍 Latest deploy log https://app.netlify.com/sites/scientific-python-hugo-theme/deploys/65132091c83fb70008711378
😎 Deploy Preview https://deploy-preview-265--scientific-python-hugo-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96
Accessibility: 100
Best Practices: 100
SEO: 89
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@stefanv
Copy link
Member

stefanv commented Sep 26, 2023

It might be my imagination, but that icon looks higher than it used to be. Could you please compare against an older version of the theme?

@jarrodmillman
Copy link
Member

@stefanv It is definitely higher and smaller. Do you prefer it lower and bigger? Or just lower, but this size?

@stefanv
Copy link
Member

stefanv commented Sep 26, 2023

I would like it to be restored to how it was, then we can discuss modifications another time.

@alphapapa
Copy link
Contributor Author

I would like it to be restored to how it was, then we can discuss modifications another time.

If we revert that, it would also mean reverting the fix that was merged in #230, and having to redesign that somehow.

I just pushed another commit to this PR that looks like this:

Screen Shot 2023-09-26 at 12 14 59

I tried to imitate the screenshot in #261 (comment) as closely as I could. It's mostly just a matter of tweaking the max-height on the .hero-icon.

@stefanv
Copy link
Member

stefanv commented Sep 26, 2023

Thanks, Adam. I think if we add a tiny bit of extra space between the text and the logo, that's close enough and we can merge.

@alphapapa
Copy link
Contributor Author

Thanks, Adam. I think if we add a tiny bit of extra space between the text and the logo, that's close enough and we can merge.

Sure, just pushed another commit that looks like this:

localhost_1313_

@stefanv
Copy link
Member

stefanv commented Sep 26, 2023

Rendering on my screen:

image

@stefanv
Copy link
Member

stefanv commented Sep 26, 2023

Worth checking different zoom levels, and also the phone/tablet emulation in the web debugger window.

@jarrodmillman
Copy link
Member

Here is what the currently deployed website looks like.
2023-09-26T12:07:24,756360960-07:00

@jarrodmillman
Copy link
Member

Here is what it looked like 5 months ago (e3516b2):
2023-09-26T12:14:48,927545478-07:00

@stefanv
Copy link
Member

stefanv commented Sep 27, 2023

Looks like it's been present, in which case we can merge this and file a new issue for it.

@alphapapa
Copy link
Contributor Author

Looks like it's been present, in which case we can merge this and file a new issue for it.

Will do. Thanks.

@alphapapa alphapapa merged commit 1de1a03 into scientific-python:main Sep 27, 2023
5 checks passed
@jarrodmillman jarrodmillman modified the milestone: 0.1 Sep 29, 2023
@alphapapa alphapapa deleted the wip/261 branch October 16, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants