-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add javascript dark toggle mode #308
Merged
stefanv
merged 5 commits into
scientific-python:main
from
jarrodmillman:pydata-theme-mode
Oct 24, 2023
Merged
Add javascript dark toggle mode #308
stefanv
merged 5 commits into
scientific-python:main
from
jarrodmillman:pydata-theme-mode
Oct 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for scientific-python-hugo-theme ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
jarrodmillman
force-pushed
the
pydata-theme-mode
branch
from
October 24, 2023 07:09
99865cc
to
1ff4d54
Compare
jarrodmillman
force-pushed
the
pydata-theme-mode
branch
from
October 24, 2023 08:01
bd79dce
to
4bd7035
Compare
stefanv
reviewed
Oct 24, 2023
I initially tried to use the themeswitcher from: https://github.com/pydata/pydata-sphinx-theme/blob/main/src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js
Co-authored-by: Stefan van der Walt <sjvdwalt@gmail.com>
jarrodmillman
force-pushed
the
pydata-theme-mode
branch
from
October 24, 2023 16:29
034202c
to
2a81072
Compare
stefanv
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to use the themeswitcher from:
https://github.com/pydata/pydata-sphinx-theme/blob/main/src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js