Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back missing pieces of bulma #318

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

stefanv
Copy link
Member

@stefanv stefanv commented Oct 25, 2023

In the previous purgeCSS run, I forgot to include JavaScript files. These sometimes set class attributes programatically, so needed to be included to prevent the hamburger, button, etc. CSS from being filtered out.

Follow-up on #317

How I generated the reduced CSS

I modified the theme Makefile to also build numpy.org. Then:

npm install -g purgecss
cd scientific-python-hugo-theme
make numpy && make scipy && make main && make blog && make learn
npx purgecss -css assets/theme-css/bulma.css -con **/public/**/*.html **/public/**/*.js | jq --raw-output ".[0].css" > /tmp/bulma.reduced.css

@netlify
Copy link

netlify bot commented Oct 25, 2023

Deploy Preview for scientific-python-hugo-theme ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e0969e1
🔍 Latest deploy log https://app.netlify.com/sites/scientific-python-hugo-theme/deploys/65397b879733150008f940cb
😎 Deploy Preview https://deploy-preview-318--scientific-python-hugo-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 75
Accessibility: 98
Best Practices: 100
SEO: 89
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@stefanv stefanv added type: Bug fix Something isn't working type: Maintenance and removed type: Bug fix Something isn't working labels Oct 25, 2023
In the previous purgeCSS run, I forgot to include JavaScript files.
These sometimes set class attributes programatically, so needed to
be included to prevent the hamburger, button, etc. CSS from being
filtered out.
@jarrodmillman jarrodmillman merged commit fadd978 into scientific-python:main Oct 25, 2023
6 checks passed
@jarrodmillman jarrodmillman added this to the 0.3 milestone Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants