Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render mermaid via code blocks, instead of shortcodes #338

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Render mermaid via code blocks, instead of shortcodes #338

merged 1 commit into from
Oct 30, 2023

Conversation

stefanv
Copy link
Member

@stefanv stefanv commented Oct 30, 2023

Will require a change to SPECs.

@netlify
Copy link

netlify bot commented Oct 30, 2023 •
edited
Loading

❌ Deploy Preview for scientific-python-hugo-theme failed.

Built without sensitive environment variables

Name Link
🔨 Latest commit 41326f6
🔍 Latest deploy log https://app.netlify.com/sites/scientific-python-hugo-theme/deploys/65401d12155ee5000827d367

@stefanv stefanv added the type: Enhancement New feature or request label Oct 30, 2023
@jarrodmillman jarrodmillman marked this pull request as draft October 30, 2023 20:21
@jarrodmillman jarrodmillman marked this pull request as ready for review October 30, 2023 21:40
jarrodmillman
jarrodmillman approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@jarrodmillman jarrodmillman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failure is expected as we need to update the SPEC repo when we update the theme.

@jarrodmillman jarrodmillman merged commit c8674eb into scientific-python:main Oct 30, 2023
2 of 6 checks passed
@jarrodmillman jarrodmillman added this to the 0.3 milestone Oct 30, 2023
@jarrodmillman jarrodmillman mentioned this pull request Oct 30, 2023
Merged
jarrodmillman added a commit to scientific-python/specs that referenced this pull request Oct 30, 2023
@jarrodmillman
Render mermaid via code blocks, instead of shortcodes (#286)
8eb294b 
See
-
scientific-python/scientific-python-hugo-theme#338
- scientific-python/scientific-python.org#518
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarrodmillman jarrodmillman jarrodmillman approved these changes

Assignees
No one assigned
Labels
type: Enhancement New feature or request
Projects
None yet
Milestone
0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanv @jarrodmillman