Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: "More" links after post summaries #391

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

alphapapa
Copy link
Contributor

@alphapapa alphapapa commented Nov 6, 2023

After exploring a number of variants ("Read more" vs. "more", arrow vs. ellipsis, left-align vs. right-aligned, in a separate paragraph vs. immediately after the summary text, italic vs. normal, small-caps variants and non-, etc.), I settled on this.

I think it would look even better (less cluttered) were it not underlined, but which links to underline is probably a wider discussion that needs to be had (or one that has been had that I'm just not aware of).

Please let me know if you'd like me to make more changes. Thanks.

Visible at: https://deploy-preview-391--scientific-python-hugo-theme.netlify.app/blog/

Copy link

netlify bot commented Nov 6, 2023

Deploy Preview for scientific-python-hugo-theme failed.

Built without sensitive environment variables

Name Link
🔨 Latest commit 17c09eb
🔍 Latest deploy log https://app.netlify.com/sites/scientific-python-hugo-theme/deploys/654987698f9e130008f90a68

@alphapapa alphapapa linked an issue Nov 6, 2023 that may be closed by this pull request
@alphapapa alphapapa self-assigned this Nov 6, 2023
@alphapapa alphapapa added the type: Enhancement New feature or request label Nov 6, 2023
@stefanv
Copy link
Member

stefanv commented Nov 6, 2023

Examples of three variants:

image

@stefanv
Copy link
Member

stefanv commented Nov 6, 2023

For now, let's render the link inline and call it a day:

image

display: inline or inline-block.

@jarrodmillman
Copy link
Member

I think we should just follow the pydata-sphinx-theme example:
https://pydata-sphinx-theme.readthedocs.io/en/stable/examples/blog/index.html

If we don't like it, I think we should make a PR to pydata-sphinx-theme and see if the community agrees. Right now, it is just the three of us working alone, but pydata-sphinx-theme has many developers from many projects providing feedback.

@jarrodmillman
Copy link
Member

If the two of you disagree, then I will go with whatever the two of you decide. If we all disagree, then I think we should go with what the community has already agreed to (i.e., the pydata-sphinx-theme styling).

@stefanv stefanv force-pushed the wip/155-more-link branch 2 times, most recently from 38a7277 to e587377 Compare November 7, 2023 00:38
@stefanv stefanv merged commit 05deadf into scientific-python:main Nov 7, 2023
0 of 5 checks passed
@jarrodmillman jarrodmillman added this to the 0.4 milestone Nov 7, 2023
@alphapapa
Copy link
Contributor Author

I think we should just follow the pydata-sphinx-theme example: https://pydata-sphinx-theme.readthedocs.io/en/stable/examples/blog/index.html

I would generally agree with that. My only hesitation is that that example page looks a bit artificial with the pretend posts having so little text, so it's hard to judge what it would look like if that theme were used on a real blog. Also, that example page seems to need a bit of polishing (e.g. the 5 lines of metadata below the title creates an awkward gap under the timestamp, which probably isn't intended).

Also, IMHO the recent trend toward every clickable thing being underlined creates excessive visual noise, even though I understand how it could aid accessibility in a sense.

If we don't like it, I think we should make a PR to pydata-sphinx-theme and see if the community agrees. Right now, it is just the three of us working alone, but pydata-sphinx-theme has many developers from many projects providing feedback.

If the two of you disagree, then I will go with whatever the two of you decide. If we all disagree, then I think we should go with what the community has already agreed to (i.e., the pydata-sphinx-theme styling).

To whatever extent my aesthetic input is sought, I think the best appearance is what I submitted, but that's just me. I'm here to serve, not to push my preferences. :)

@stefanv
Copy link
Member

stefanv commented Nov 7, 2023

Thanks, Adam; I think your aesthetic input was good. It's a bit of a balancing game between doing what we think is optimal and getting ourselves in alignment with the PDST. I guess we're leaning a bit towards that side right now, but fortunately we have room to adjust in the future.

I see the everything clickable underlined trend is now on GitHub as well, so I guess we'll ride it out and see where it lands. Our hope is to ultimately have styling decisions being made on PDST, and automatically propagate here. I.e., not having to worry about it :)

@alphapapa alphapapa deleted the wip/155-more-link branch November 7, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Idea: "More..." link at the end of summaries
3 participants