-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: "More" links after post summaries #391
Conversation
❌ Deploy Preview for scientific-python-hugo-theme failed.Built without sensitive environment variables
|
e6f4591
to
5df4b9c
Compare
5df4b9c
to
b87a45e
Compare
I think we should just follow the pydata-sphinx-theme example: If we don't like it, I think we should make a PR to pydata-sphinx-theme and see if the community agrees. Right now, it is just the three of us working alone, but pydata-sphinx-theme has many developers from many projects providing feedback. |
If the two of you disagree, then I will go with whatever the two of you decide. If we all disagree, then I think we should go with what the community has already agreed to (i.e., the pydata-sphinx-theme styling). |
38a7277
to
e587377
Compare
e587377
to
17c09eb
Compare
I would generally agree with that. My only hesitation is that that example page looks a bit artificial with the pretend posts having so little text, so it's hard to judge what it would look like if that theme were used on a real blog. Also, that example page seems to need a bit of polishing (e.g. the 5 lines of metadata below the title creates an awkward gap under the timestamp, which probably isn't intended). Also, IMHO the recent trend toward every clickable thing being underlined creates excessive visual noise, even though I understand how it could aid accessibility in a sense.
To whatever extent my aesthetic input is sought, I think the best appearance is what I submitted, but that's just me. I'm here to serve, not to push my preferences. :) |
Thanks, Adam; I think your aesthetic input was good. It's a bit of a balancing game between doing what we think is optimal and getting ourselves in alignment with the PDST. I guess we're leaning a bit towards that side right now, but fortunately we have room to adjust in the future. I see the everything clickable underlined trend is now on GitHub as well, so I guess we'll ride it out and see where it lands. Our hope is to ultimately have styling decisions being made on PDST, and automatically propagate here. I.e., not having to worry about it :) |
After exploring a number of variants ("Read more" vs. "more", arrow vs. ellipsis, left-align vs. right-aligned, in a separate paragraph vs. immediately after the summary text, italic vs. normal, small-caps variants and non-, etc.), I settled on this.
I think it would look even better (less cluttered) were it not underlined, but which links to underline is probably a wider discussion that needs to be had (or one that has been had that I'm just not aware of).
Please let me know if you'd like me to make more changes. Thanks.
Visible at: https://deploy-preview-391--scientific-python-hugo-theme.netlify.app/blog/