Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase color contrast in footer #459

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

jarrodmillman
Copy link
Member

Fix #457. I am using the same hoover color as used in the about button and news banner.

2024-01-26T08:22:48,295534305-08:00

https://coolors.co/contrast-checker/4dabcf-013243

@jarrodmillman jarrodmillman added the type: Enhancement New feature or request label Jan 26, 2024
Copy link

netlify bot commented Jan 26, 2024

Deploy Preview for scientific-python-hugo-theme ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b5aa085
🔍 Latest deploy log https://app.netlify.com/sites/scientific-python-hugo-theme/deploys/65b3dc890564f700086d5467
😎 Deploy Preview https://deploy-preview-459--scientific-python-hugo-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 83
Accessibility: 100
Best Practices: 100
SEO: 92
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@jarrodmillman
Copy link
Member Author

I am going to merge this and close the issue. This is much better than what we had, but we still need to revisit this when we do our accessibility audit.

@jarrodmillman jarrodmillman merged commit 5674a9c into scientific-python:main Jan 26, 2024
7 checks passed
@jarrodmillman jarrodmillman deleted the footer-links branch January 26, 2024 17:35
@jarrodmillman jarrodmillman added this to the 0.9 milestone Jan 26, 2024
@melissawm
Copy link
Member

Thanks for the swift response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color contrast on page footer
3 participants